Commit 68887582 authored Mar 10, 2016 by Hannes Reinecke Committed by Martin K. Petersen Mar 10, 2016

scsi_sysfs: Fix typo in is_bin_visible()



The test for the existence vpd_pg83 is inverted.

Fixes: 7e47976b ("scsi_sysfs: add 'is_bin_visible' callback")
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 30845586

drivers/scsi/scsi_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1105,7 +1105,7 @@ static umode_t scsi_sdev_bin_attr_is_visible(struct kobject *kobj,
		if (attr == &dev_attr_vpd_pg80 && !sdev->vpd_pg80)
		return 0;

		if (attr == &dev_attr_vpd_pg83 && sdev->vpd_pg83)
		if (attr == &dev_attr_vpd_pg83 && !sdev->vpd_pg83)
		return 0;

		return S_IRUGO;