Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6871e814 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix NVME Target crash in defer rcv logic 



Kernel occasionally crashed with the following
ops on NVME Target:
  BUG: unable to handle kernel NULL pointer dereference at 0000000000000058
  IP: [<ffffffffa042ee50>] lpfc_nvmet_defer_rcv+0x50/0x70 [lpfc]

Callback routine was called for deferred rcv when it should be treated as a
normal rcv.

Added code in callback routine to detect this condition and log a message,
then bail.

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 66e9e6bf

drivers/scsi/lpfc/lpfc_nvmet.c

+11 −1
Original line number Diff line number Diff line
@@ -402,6 +402,7 @@ lpfc_nvmet_ctxbuf_post(struct lpfc_hba *phba, struct lpfc_nvmet_ctxbuf *ctx_buf) 


		/* Process FCP command */

		if (rc == 0) {

			ctxp->rqb_buffer = NULL;

			atomic_inc(&tgtp->rcv_fcp_cmd_out);

			nvmebuf->hrq->rqbp->rqb_free_buffer(phba, nvmebuf);

			return;
@@ -1116,7 +1117,16 @@ lpfc_nvmet_defer_rcv(struct nvmet_fc_target_port *tgtport, 
	lpfc_nvmeio_data(phba, "NVMET DEFERRCV: xri x%x sz %d CPU %02x\n",

			 ctxp->oxid, ctxp->size, smp_processor_id());



	if (!nvmebuf) {

		lpfc_printf_log(phba, KERN_INFO, LOG_NVME_IOERR,

				"6425 Defer rcv: no buffer xri x%x: "

				"flg %x ste %x\n",

				ctxp->oxid, ctxp->flag, ctxp->state);

		return;

	}



	tgtp = phba->targetport->private;

	if (tgtp)

		atomic_inc(&tgtp->rcv_fcp_cmd_defer);



	/* Free the nvmebuf since a new buffer already replaced it */