Commit 68693b8e authored Dec 11, 2014 by Sebastian Andrzej Siewior Committed by Felipe Balbi Dec 22, 2014

usb: musb: stuff leak of struct usb_hcd



since the split of host+gadget mode in commit 74c2e936 ("usb: musb:
factor out hcd initalization") we leak the usb_hcd struct. We call now
musb_host_cleanup() which does basically usb_remove_hcd() and also sets
the hcd variable to NULL. Doing so makes the finall call to
musb_host_free() basically a nop and the usb_hcd remains around for ever
without anowner.
This patch drops that NULL assignment for that reason.

Fixes: 74c2e936 ("usb: musb: factor out hcd initalization")
Cc: <stable@vger.kernel.org> # v3.11+
Cc: Daniel Mack <zonque@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 62f4f065

drivers/usb/musb/musb_host.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2663,7 +2663,6 @@ void musb_host_cleanup(struct musb *musb)
		if (musb->port_mode == MUSB_PORT_MODE_GADGET)
		return;
		usb_remove_hcd(musb->hcd);
		musb->hcd = NULL;
		}

		void musb_host_free(struct musb *musb)