Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6812cb0d authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman
Browse files

spi: spi-pic32: Fix issue with uninitialized dma_slave_config 



[ Upstream commit 976c1de1de147bb7f4e0d87482f375221c05aeaf ]

Depending on the DMA driver being used, the struct dma_slave_config may
need to be initialized to zero for the unused data.

For example, we have three DMA drivers using src_port_window_size and
dst_port_window_size. If these are left uninitialized, it can cause DMA
failures.

For spi-pic32, this is probably not currently an issue but is still good to
fix though.

Fixes: 1bcb9f8c ("spi: spi-pic32: Add PIC32 SPI master driver")
Cc: Purna Chandra Mandal <purna.mandal@microchip.com>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20210810081727.19491-2-tony@atomide.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent bcc9379c

drivers/spi/spi-pic32.c

+1 −0
Original line number Diff line number Diff line
@@ -369,6 +369,7 @@ static int pic32_spi_dma_config(struct pic32_spi *pic32s, u32 dma_width) 
	struct dma_slave_config cfg;

	int ret;



	memset(&cfg, 0, sizeof(cfg));

	cfg.device_fc = true;

	cfg.src_addr = pic32s->dma_base + buf_offset;

	cfg.dst_addr = pic32s->dma_base + buf_offset;