Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67e5871b authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm/i915: Drop forcewake w/a for missed interrupts/seqno on Sandybridge 



I believe, and an evening of i-g-t, that our original workaround for the
missed interrupts on Sandybridge, that of holding forcewake whilst we
wait for an interrupts, is no longer required. This leaves us dependent
on the second workaround of forcing an UC read of the ACTHD before
reading back the seqno from the snooped HWS. Dropping the forcewake
should allow us to conserve a little power, not much as the GPU is meant
to be busy whilst we wait for it!

Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 5ed16782

drivers/gpu/drm/i915/intel_ringbuffer.c

+0 −7
Original line number Diff line number Diff line
@@ -1032,11 +1032,6 @@ gen6_ring_get_irq(struct intel_ring_buffer *ring) 
	if (!dev->irq_enabled)

	       return false;



	/* It looks like we need to prevent the gt from suspending while waiting

	 * for an notifiy irq, otherwise irqs seem to get lost on at least the

	 * blt/bsd rings on ivb. */

	gen6_gt_force_wake_get(dev_priv);



	spin_lock_irqsave(&dev_priv->irq_lock, flags);

	if (ring->irq_refcount++ == 0) {

		if (HAS_L3_DPF(dev) && ring->id == RCS)
@@ -1068,8 +1063,6 @@ gen6_ring_put_irq(struct intel_ring_buffer *ring) 
		ilk_disable_gt_irq(dev_priv, ring->irq_enable_mask);

	}

	spin_unlock_irqrestore(&dev_priv->irq_lock, flags);



	gen6_gt_force_wake_put(dev_priv);

}



static bool