Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6715ca45 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

signals: collect_signal: remove the unneeded sigismember() check 



collect_signal() checks sigismember(&list->signal, sig), this is not
needed.  This "sig" was just found by next_signal(), so it must be valid.

We have a (completely broken) call to ->notifier in between, but it must
not play with sigpending->signal bits or unlock ->siglock.

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Acked-by: default avatarRoland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 96347e77

kernel/signal.c

+0 −3
Original line number Diff line number Diff line
@@ -343,9 +343,6 @@ static int collect_signal(int sig, struct sigpending *list, siginfo_t *info) 
	struct sigqueue *q, *first = NULL;

	int still_pending = 0;



	if (unlikely(!sigismember(&list->signal, sig)))

		return 0;



	/*

	 * Collect the siginfo appropriate to this signal.  Check if

	 * there is another siginfo for the same signal.