Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6704af53 authored by Patrick McHardy's avatar Patrick McHardy Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_conntrack: remove net_ratelimit() for LOG_INVALID() 



Logging of invalid packets has to be explicitly enabled. Rate-limiting these
messages is inconsistent with other netfilter logging features and makes
debugging harder.

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 5774c94a

include/net/netfilter/nf_conntrack_l4proto.h

+0 −7
Original line number Diff line number Diff line
@@ -148,17 +148,10 @@ extern int nf_ct_port_nlattr_tuple_size(void); 
extern const struct nla_policy nf_ct_port_nla_policy[];



#ifdef CONFIG_SYSCTL

#ifdef DEBUG_INVALID_PACKETS

#define LOG_INVALID(net, proto)				\

	((net)->ct.sysctl_log_invalid == (proto) ||	\

	 (net)->ct.sysctl_log_invalid == IPPROTO_RAW)

#else

#define LOG_INVALID(net, proto)				\

	(((net)->ct.sysctl_log_invalid == (proto) ||	\

	  (net)->ct.sysctl_log_invalid == IPPROTO_RAW)	\

	 && net_ratelimit())

#endif

#else

static inline int LOG_INVALID(struct net *net, int proto) { return 0; }

#endif /* CONFIG_SYSCTL */