Commit 66dede2d authored Feb 15, 2018 by Davide Caratti Committed by David S. Miller Feb 16, 2018

net: sched: fix unbalance in the error path of tca_action_flush()



When tca_action_flush() calls the action walk() and gets an error,
a successful call to nla_nest_start() is not followed by a call to
nla_nest_cancel(). It's harmless, as the skb is freed in the error
path - but it's worth to fix this unbalance.

Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e5fe068a

net/sched/act_api.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -938,8 +938,10 @@ static int tca_action_flush(struct net net, struct nlattr nla,
		goto out_module_put;

		err = ops->walk(net, skb, &dcb, RTM_DELACTION, ops);
		if (err <= 0)
		if (err <= 0) {
		nla_nest_cancel(skb, nest);
		goto out_module_put;
		}

		nla_nest_end(skb, nest);