Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66cf3504 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by David S. Miller
Browse files

net/ethernet: tundra: fix dump_eth_one warning in tsi108_eth 



The call site for this function appears as:

  #ifdef DEBUG
        data->msg_enable = DEBUG;
        dump_eth_one(dev);
  #endif

...leading to the following warning for !DEBUG builds:

drivers/net/ethernet/tundra/tsi108_eth.c:169:13: warning: 'dump_eth_one' defined but not used [-Wunused-function]
 static void dump_eth_one(struct net_device *dev)
             ^

...when using the arch/powerpc/configs/mpc7448_hpc2_defconfig

Put the function definition under the same #ifdef as the call site
to avoid the warning.

Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 61ec4bce

drivers/net/ethernet/tundra/tsi108_eth.c

+2 −0
Original line number Diff line number Diff line
@@ -166,6 +166,7 @@ static struct platform_driver tsi_eth_driver = { 


static void tsi108_timed_checker(unsigned long dev_ptr);



#ifdef DEBUG

static void dump_eth_one(struct net_device *dev)

{

	struct tsi108_prv_data *data = netdev_priv(dev);
@@ -190,6 +191,7 @@ static void dump_eth_one(struct net_device *dev) 
	       TSI_READ(TSI108_EC_RXESTAT),

	       TSI_READ(TSI108_EC_RXERR), data->rxpending);

}

#endif



/* Synchronization is needed between the thread and up/down events.

 * Note that the PHY is accessed through the same registers for both