Commit 66a7c84d authored Nov 22, 2017 by Colin Ian King Committed by Wolfram Sang Nov 27, 2017

i2c: i2c-boardinfo: fix memory leaks on devinfo



Currently when an error occurs devinfo is still allocated but is
unused when the error exit paths break out of the for-loop. Fix
this by kfree'ing devinfo to avoid the leak.

Detected by CoverityScan, CID#1416590 ("Resource Leak")

Fixes: 4124c4eb ("i2c: allow attaching IRQ resources to i2c_board_info")
Fixes: 0daaf99d ("i2c: copy device properties when using i2c_register_board_info()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent 6e0c9507

drivers/i2c/i2c-boardinfo.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -86,6 +86,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig
		property_entries_dup(info->properties);
		if (IS_ERR(devinfo->board_info.properties)) {
		status = PTR_ERR(devinfo->board_info.properties);
		kfree(devinfo);
		break;
		}
		}
		@@ -98,6 +99,7 @@ int i2c_register_board_info(int busnum, struct i2c_board_info const *info, unsig
		GFP_KERNEL);
		if (!devinfo->board_info.resources) {
		status = -ENOMEM;
		kfree(devinfo);
		break;
		}
		}