Commit 66761522 authored Apr 23, 2007 by Markus F.X.J. Oberhumer Committed by Tony Luck May 08, 2007

[IA64] fix stack alignment for ia32 signal handlers

This fixes the setup of the alignment of the signal frame, so that all
signal handlers are run with a properly aligned stack frame.

The current code "over-aligns" the stack pointer so that the stack frame
is effectively always mis-aligned by 4 bytes. But what we really want
is that on function entry ((sp + 4) & 15) == 0, which matches what would
happen if the stack were aligned before a "call" instruction.

i386 and x86_64 are already fixed by d347f372

Signed-off-by: Markus F.X.J. Oberhumer <markus@oberhumer.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>

parent 0e17b560

arch/ia64/ia32/ia32_signal.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -811,7 +811,11 @@ get_sigframe (struct k_sigaction ka, struct pt_regs regs, size_t frame_size)
		}
		/* Legacy stack switching not supported */

		return (void __user *)((esp - frame_size) & -8ul);
		esp -= frame_size;
		/* Align the stack pointer according to the i386 ABI,
		* i.e. so that on function entry ((sp + 4) & 15) == 0. */
		esp = ((esp + 4) & -16ul) - 4;
		return (void __user *) esp;
		}

		static int