Commit 6670f15b authored Feb 09, 2012 by Amitkumar Karwar Committed by John W. Linville Feb 15, 2012

mwifiex: clear previous security setting during association



Driver maintains different flags for WEP, WPA, WPA2 security modes.
Appropriate flag is set using security information provided in
connect request. mwifiex_is_network_compatible() routine uses them
to check if driver's setting is compatible with AP. Association is
aborted if the routine fails.

For some corner cases, it is observed that association is failed
even for valid security information based on association history.
This patch fixes the problem by clearing previous security setting
during each association.

We should set WEP key provided in connect request as default tx key.
This missing change is also added here.

Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 216c57b2

drivers/net/wireless/mwifiex/cfg80211.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -841,7 +841,12 @@ mwifiex_cfg80211_assoc(struct mwifiex_private priv, size_t ssid_len, u8 ssid,
		ret = mwifiex_set_rf_channel(priv, channel,
		priv->adapter->channel_type);

		ret = mwifiex_set_encode(priv, NULL, 0, 0, 1); /* Disable keys */
		/* As this is new association, clear locally stored
		* keys and security related flags */
		priv->sec_info.wpa_enabled = false;
		priv->sec_info.wpa2_enabled = false;
		priv->wep_key_curr_index = 0;
		ret = mwifiex_set_encode(priv, NULL, 0, 0, 1);

		if (mode == NL80211_IFTYPE_ADHOC) {
		/* "privacy" is set only for ad-hoc mode */
		@@ -886,6 +891,7 @@ mwifiex_cfg80211_assoc(struct mwifiex_private priv, size_t ssid_len, u8 ssid,
		dev_dbg(priv->adapter->dev,
		"info: setting wep encryption"
		" with key len %d\n", sme->key_len);
		priv->wep_key_curr_index = sme->key_idx;
		ret = mwifiex_set_encode(priv, sme->key, sme->key_len,
		sme->key_idx, 0);
		}