Commit 667026e7 authored Feb 27, 2009 by Andy Whitcroft Committed by Linus Torvalds Feb 27, 2009

checkpatch: a modifier is not an identifier at the end of a type



We must make sure we do not misrecognise a modifier as an Identifier
when trying to match types.  Prevent us matching this:

	void * __ref

Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent a3340b35

scripts/checkpatch.pl

+2 −2

Original line number	Diff line number	Diff line
		@@ -1686,8 +1686,8 @@ sub process {
		# Modifiers should have spaces.
		$to =~ s/(\b$Modifier$)/$1 /;

		#print "from<$from> to<$to>\n";
		if ($from ne $to) {
		#print "from<$from> to<$to> ident<$ident>\n";
		if ($from ne $to && $ident !~ /^$Modifier$/) {
		ERROR("\"foo${from}bar\" should be \"foo${to}bar\"\n" . $herecurr);
		}
		}