Commit 6637e6f1 authored Aug 15, 2016 by Colin Ian King Committed by Arnaldo Carvalho de Melo Aug 23, 2016

perf hists browser: Remove superfluous null check on map



'map' is being already checked if it is NULL at the start of
do_zoom_dso(), so the second subsequent check is superfluous and can be
removed.

Signed-off-by: Colin King <colin.king@canonical.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1471278343-14999-1-git-send-email-colin.king@canonical.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 11196b79

tools/perf/ui/browsers/hists.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2440,8 +2440,6 @@ do_zoom_dso(struct hist_browser browser, struct popup_action act)
		browser->hists->dso_filter = NULL;
		ui_helpline__pop();
		} else {
		if (map == NULL)
		return 0;
		ui_helpline__fpush("To zoom out press ESC or ENTER + \"Zoom out of %s DSO\"",
		__map__is_kernel(map) ? "the Kernel" : map->dso->short_name);
		browser->hists->dso_filter = map->dso;