Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6636fa3c authored by Monam Agarwal's avatar Monam Agarwal Committed by Greg Kroah-Hartman
Browse files

Staging: rts5139: Fix incorrect type in assignment in rts51x_fop.c 



This patch fixes following sparse warning in rts51x_fop.c
Warning: incorrect type in assignment

Signed-off-by: default avatarMonam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent abe5d64d

drivers/staging/rts5139/rts51x_fop.c

+5 −5
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip, 
		}



		retval =

		    copy_to_user((void *)cmnd->buf, (void *)buf, cmnd->buf_len);

		    copy_to_user(cmnd->buf, (void *)buf, cmnd->buf_len);

		if (retval) {

			kfree(buf);

			TRACE_RET(chip, STATUS_NOMEM);
@@ -109,7 +109,7 @@ static int rts51x_sd_direct_cmnd(struct rts51x_chip *chip, 
			TRACE_RET(chip, STATUS_NOMEM);



		retval =

		    copy_from_user((void *)buf, (void *)cmnd->buf,

		    copy_from_user((void *)buf, cmnd->buf,

				   cmnd->buf_len);

		if (retval) {

			kfree(buf);
@@ -154,7 +154,7 @@ static int rts51x_sd_get_rsp(struct rts51x_chip *chip, struct sd_rsp *rsp) 
	else

		count = (rsp->rsp_len < 6) ? rsp->rsp_len : 6;



	retval = copy_to_user((void *)rsp->rsp, (void *)sd_card->rsp, count);

	retval = copy_to_user(rsp->rsp, (void *)sd_card->rsp, count);

	if (retval)

		TRACE_RET(chip, STATUS_NOMEM);
@@ -250,7 +250,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
	switch (cmd) {

	case RTS5139_IOC_SD_DIRECT:

		retval =

		    copy_from_user((void *)&cmnd, (void *)arg,

		    copy_from_user((void *)&cmnd, (void __user *)arg,

				   sizeof(struct sd_direct_cmnd));

		if (retval) {

			retval = -ENOMEM;
@@ -265,7 +265,7 @@ long rts51x_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 


	case RTS5139_IOC_SD_GET_RSP:

		retval =

		    copy_from_user((void *)&rsp, (void *)arg,

		    copy_from_user(&rsp, (void __user *)arg,

				   sizeof(struct sd_rsp));

		if (retval) {

			retval = -ENOMEM;

drivers/staging/rts5139/rts51x_fop.h

+2 −2
Original line number Diff line number Diff line
@@ -35,12 +35,12 @@ 


struct sd_direct_cmnd {

	u8 cmnd[12];

	void *buf;

	void __user *buf;

	int buf_len;

};



struct sd_rsp {

	void *rsp;

	void __user *rsp;

	int rsp_len;

};