Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66303bce authored by David Howells's avatar David Howells Committed by James Morris
Browse files

CRED: Wrap task credential accesses in the tty driver 



Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJames Morris <jmorris@namei.org>
Acked-by: default avatarSerge Hallyn <serue@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent b0fafa81

drivers/char/tty_audit.c

+4 −2
Original line number Diff line number Diff line
@@ -86,10 +86,12 @@ static void tty_audit_buf_push(struct task_struct *tsk, uid_t loginuid, 
	ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_TTY);

	if (ab) {

		char name[sizeof(tsk->comm)];

		uid_t uid = task_uid(tsk);



		audit_log_format(ab, "tty pid=%u uid=%u auid=%u ses=%u "

				 "major=%d minor=%d comm=", tsk->pid, tsk->uid,

				 loginuid, sessionid, buf->major, buf->minor);

				 "major=%d minor=%d comm=",

				 tsk->pid, uid, loginuid, sessionid,

				 buf->major, buf->minor);

		get_task_comm(name, tsk);

		audit_log_untrustedstring(ab, name);

		audit_log_format(ab, " data=");