Commit 65f2767a authored Feb 23, 2017 by Florian Fainelli Committed by David S. Miller Feb 24, 2017

net: phy: Add missing driver check in phy_aneg_done()



Dan's static checker caught a potential code path in phy_state_machine() where
we were not checking phydev->drv which is in phy_aneg_done().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 25149ef9 ("net: phy: Check phydev->drv")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4e37d691

drivers/net/phy/phy.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ static int phy_config_interrupt(struct phy_device *phydev, u32 interrupts)
		*/
		int phy_aneg_done(struct phy_device *phydev)
		{
		if (phydev->drv->aneg_done)
		if (phydev->drv && phydev->drv->aneg_done)
		return phydev->drv->aneg_done(phydev);

		return genphy_aneg_done(phydev);