Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65be3226 authored by Lukas Wunner's avatar Lukas Wunner Committed by Greg Kroah-Hartman
Browse files

mmc: bcm2835: Fix DMA channel leak on probe error 



commit 8c9620b1cc9b69e82fa8d4081d646d0016b602e7 upstream.

The BCM2835 MMC host driver requests a DMA channel on probe but neglects
to release the channel in the probe error path.  The channel may
therefore be leaked, in particular if devm_clk_get() causes probe
deferral.  Fix it.

Fixes: 660fc733 ("mmc: bcm2835: Add new driver for the sdhost controller.")
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v4.12+
Cc: Frank Pavlic <f.pavlic@kunbus.de>
Tested-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8b9be9db

drivers/mmc/host/bcm2835.c

+2 −0
Original line number Diff line number Diff line
@@ -1427,6 +1427,8 @@ static int bcm2835_probe(struct platform_device *pdev) 


err:

	dev_dbg(dev, "%s -> err %d\n", __func__, ret);

	if (host->dma_chan_rxtx)

		dma_release_channel(host->dma_chan_rxtx);

	mmc_free_host(mmc);



	return ret;