Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65ad72ce authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Greg Kroah-Hartman
Browse files

i2c: designware: Synchronize IRQs when unregistering slave client 



[ Upstream commit c486dcd2f1bbdd524a1e0149734b79e4ae329650 ]

Make sure interrupt handler i2c_dw_irq_handler_slave() has finished
before clearing the the dev->slave pointer in i2c_dw_unreg_slave().

There is possibility for a race if i2c_dw_irq_handler_slave() is running
on another CPU while clearing the dev->slave pointer.

Reported-by: default avatarKrzysztof Adamski <krzysztof.adamski@nokia.com>
Reported-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5a45b14b

drivers/i2c/busses/i2c-designware-slave.c

+1 −0
Original line number Diff line number Diff line
@@ -94,6 +94,7 @@ static int i2c_dw_unreg_slave(struct i2c_client *slave) 


	dev->disable_int(dev);

	dev->disable(dev);

	synchronize_irq(dev->irq);

	dev->slave = NULL;

	pm_runtime_put(dev->dev);