Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 65a29da1 authored by Benjamin Poirier's avatar Benjamin Poirier Committed by Jeff Kirsher
Browse files

e1000e: Fix wrong comment related to link detection 



Reading e1000e_check_for_copper_link() shows that get_link_status is set to
false after link has been detected. Therefore, it stays TRUE until then.

Signed-off-by: default avatarBenjamin Poirier <bpoirier@suse.com>
Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent c4c40e51

drivers/net/ethernet/intel/e1000e/netdev.c

+2 −2
Original line number Diff line number Diff line
@@ -5074,7 +5074,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter) 


	/* get_link_status is set on LSC (link status) interrupt or

	 * Rx sequence error interrupt.  get_link_status will stay

	 * false until the check_for_link establishes link

	 * true until the check_for_link establishes link

	 * for copper adapters ONLY

	 */

	switch (hw->phy.media_type) {
@@ -5092,7 +5092,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter) 
		break;

	case e1000_media_type_internal_serdes:

		ret_val = hw->mac.ops.check_for_link(hw);

		link_active = adapter->hw.mac.serdes_has_link;

		link_active = hw->mac.serdes_has_link;

		break;

	default:

	case e1000_media_type_unknown: