Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6586b14c authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (pmbus) Use device specific function to read fan configuration 



Fan control implementation tends to be device specific, so start using
the device specific function call to read fan configuration registers.

Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
Reviewed-by: default avatarTom Grennan <tom.grennan@ericsson.com>
parent 2cfa6aed

drivers/hwmon/pmbus_core.c

+2 −4
Original line number Diff line number Diff line
@@ -1295,9 +1295,7 @@ static void pmbus_add_fan_attributes(struct i2c_client *client, 
				break;



			if (!pmbus_check_word_register(client, page,

						       pmbus_fan_registers[f])

			    || !pmbus_check_byte_register(client, page,

						pmbus_fan_config_registers[f]))

						       pmbus_fan_registers[f]))

				break;



			/*
@@ -1305,7 +1303,7 @@ static void pmbus_add_fan_attributes(struct i2c_client *client, 
			 * Each fan configuration register covers multiple fans,

			 * so we have to do some magic.

			 */

			regval = pmbus_read_byte_data(client, page,

			regval = _pmbus_read_byte_data(client, page,

				pmbus_fan_config_registers[f]);

			if (regval < 0 ||

			    (!(regval & (PB_FAN_1_INSTALLED >> ((f & 1) * 4)))))