Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 656a22a1 authored by Takashi Iwai's avatar Takashi Iwai Committed by Mark Brown
Browse files

ASoC: mid-x86: Use WARN_ON() instead of BUG_ON() 



BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent fb2e3e70

sound/soc/mid-x86/sst_platform.c

+4 −2
Original line number Diff line number Diff line
@@ -40,7 +40,8 @@ static DEFINE_MUTEX(sst_lock); 


int sst_register_dsp(struct sst_device *dev)

{

	BUG_ON(!dev);

	if (WARN_ON(!dev))

		return -EINVAL;

	if (!try_module_get(dev->dev->driver->owner))

		return -ENODEV;

	mutex_lock(&sst_lock);
@@ -59,7 +60,8 @@ EXPORT_SYMBOL_GPL(sst_register_dsp); 


int sst_unregister_dsp(struct sst_device *dev)

{

	BUG_ON(!dev);

	if (WARN_ON(!dev))

		return -EINVAL;

	if (dev != sst)

		return -EINVAL;