Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6552f327 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (nct7904) Strengthen detect function 



The bank register has five unused bits. Verify that those bits are zero
to strengthen the detect function.

Cc: Vadim V. Vlasov <vvlasov@dev.rtsoft.ru>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
parent 9c947d25

drivers/hwmon/nct7904.c

+2 −1
Original line number Diff line number Diff line
@@ -502,7 +502,8 @@ static int nct7904_detect(struct i2c_client *client, 
	/* Determine the chip type. */

	if (i2c_smbus_read_byte_data(client, VENDOR_ID_REG) != NUVOTON_ID ||

	    i2c_smbus_read_byte_data(client, CHIP_ID_REG) != NCT7904_ID ||

	    (i2c_smbus_read_byte_data(client, DEVICE_ID_REG) & 0xf0) != 0x50)

	    (i2c_smbus_read_byte_data(client, DEVICE_ID_REG) & 0xf0) != 0x50 ||

	    (i2c_smbus_read_byte_data(client, BANK_SEL_REG) & 0xf8) != 0x00)

		return -ENODEV;



	strlcpy(info->type, "nct7904", I2C_NAME_SIZE);