Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6541aef0 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

cpufreq: Drop unnecessary checks from show() and store() 



The show() and store() routines in the cpufreq core don't need to
check if the struct freq_attr they want to use really provides the
callbacks they need as expected (if that's not the case, it means
a bug in the code anyway), so change them to avoid doing that.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
parent dd02a3d9

drivers/cpufreq/cpufreq.c

+5 −16
Original line number Original line Diff line number Diff line
@@ -818,12 +818,7 @@ static ssize_t show(struct kobject *kobj, struct attribute *attr, char *buf) 
	ssize_t ret;

	ssize_t ret;





	down_read(&policy->rwsem);

	down_read(&policy->rwsem);



	if (fattr->show)

	ret = fattr->show(policy, buf);

	ret = fattr->show(policy, buf);

	else

		ret = -EIO;



	up_read(&policy->rwsem);

	up_read(&policy->rwsem);





	return ret;

	return ret;
@@ -838,18 +833,12 @@ static ssize_t store(struct kobject *kobj, struct attribute *attr, 




	get_online_cpus();

	get_online_cpus();





	if (!cpu_online(policy->cpu))

	if (cpu_online(policy->cpu)) {

		goto unlock;



		down_write(&policy->rwsem);

		down_write(&policy->rwsem);



	if (fattr->store)

		ret = fattr->store(policy, buf, count);

		ret = fattr->store(policy, buf, count);

	else

		ret = -EIO;



		up_write(&policy->rwsem);

		up_write(&policy->rwsem);

unlock:

	}



	put_online_cpus();

	put_online_cpus();





	return ret;

	return ret;