Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 650b57b0 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

gpio: mockup: tweak gpio_mockup_event_write() 



Invert the logic of the irq_enabled check and only access the private
data after the input is sanitized.

Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 6f9b3e77

drivers/gpio/gpio-mockup.c

+10 −11
Original line number Diff line number Diff line
@@ -210,24 +210,23 @@ static ssize_t gpio_mockup_event_write(struct file *file, 
	struct gpio_chip *gc;

	int rv, val;



	sfile = file->private_data;

	priv = sfile->private;

	desc = priv->desc;

	chip = priv->chip;

	gc = &chip->gc;



	rv = kstrtoint_from_user(usr_buf, size, 0, &val);

	if (rv)

		return rv;

	if (val != 0 && val != 1)

		return -EINVAL;



	if (!chip->lines[priv->offset].irq_enabled)

		return size;

	sfile = file->private_data;

	priv = sfile->private;

	desc = priv->desc;

	chip = priv->chip;

	gc = &chip->gc;



	if (chip->lines[priv->offset].irq_enabled) {

		gpiod_set_value_cansleep(desc, val);

		priv->chip->irq_ctx.irq = gc->irq_base + priv->offset;

		irq_work_queue(&priv->chip->irq_ctx.work);

	}



	return size;

}