Commit 644caa32 authored Feb 16, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Mar 04, 2021

Input: sur40 - fix an error code in sur40_probe()



[ Upstream commit b0b7d2815839024e5181bd2572f5d8d4f65363b3 ]

If v4l2_ctrl_handler_setup() fails then probe() should return an error
code instead of returning success.

Fixes: cee1e3e2 ("media: add video control handlers using V4L2 control framework")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YBKFkbATXa5fA3xj@mwanda


Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 98a31a66

drivers/input/touchscreen/sur40.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -778,6 +778,7 @@ static int sur40_probe(struct usb_interface *interface,
		dev_err(&interface->dev,
		"Unable to register video controls.");
		v4l2_ctrl_handler_free(&sur40->hdl);
		error = sur40->hdl.error;
		goto err_unreg_v4l2;
		}