Commit 644a9d3b authored Nov 16, 2012 by Axel Lin Committed by Greg Kroah-Hartman Nov 16, 2012

misc: apds9802als: Fix the logic checking timeout in als_wait_for_data_ready()



In the case of timeout waiting for data ready, the retry variable is -1.
This also fixes a bug: current code returns -ETIMEDOUT if latest retry success
( which means retry is 0 when exiting the while loop ).

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ebf1b764

drivers/misc/apds9802als.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -68,7 +68,7 @@ static int als_wait_for_data_ready(struct device *dev)
		ret = i2c_smbus_read_byte_data(client, 0x86);
		} while (!(ret & 0x80) && retry--);

		if (!retry) {
		if (retry < 0) {
		dev_warn(dev, "timeout waiting for data ready\n");
		return -ETIMEDOUT;
		}