Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 644a1f19 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Bartosz Golaszewski
Browse files

eeprom: at24: fix reading from 24MAC402/24MAC602 



Chip datasheet mentions that word addresses other than the actual
start position of the MAC delivers undefined results. So fix this.
Current implementation doesn't work due to this wrong offset.

Cc: stable@vger.kernel.org
Fixes: 0b813658 ("eeprom: at24: add support for at24mac series")
Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 5478e478

drivers/misc/eeprom/at24.c

+2 −1
Original line number Diff line number Diff line
@@ -425,7 +425,8 @@ static ssize_t at24_eeprom_read_mac(struct at24_data *at24, char *buf, 
	memset(msg, 0, sizeof(msg));

	msg[0].addr = client->addr;

	msg[0].buf = addrbuf;

	addrbuf[0] = 0x90 + offset;

	/* EUI-48 starts from 0x9a, EUI-64 from 0x98 */

	addrbuf[0] = 0xa0 - at24->chip.byte_len + offset;

	msg[0].len = 1;

	msg[1].addr = client->addr;

	msg[1].flags = I2C_M_RD;