Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6404e88e authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

resources: Set type in __request_region() 

We don't set the type (I/O, memory, etc.) of resources added by
__request_region(), which leads to confusing messages like this:

    address space collision: [io  0x1000-0x107f] conflicts with ACPI CPU throttle [??? 0x00001010-0x00001015 flags 0x80000000]

Set the type of a new resource added by __request_region() (used by
request_region() and request_mem_region()) to the type of its parent.  This
makes the resource tree internally consistent and fixes messages like the
above, where the ACPI CPU throttle resource really is an I/O port region,
but request_region() didn't fill in the type, so %pR didn't know how to
print it.

Sample dmesg showing the issue at the link below.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=71611


Reported-by: default avatarPaul Bolle <pebolle@tiscali.nl>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent e20fa660

kernel/resource.c

+2 −2
Original line number Diff line number Diff line
@@ -945,8 +945,8 @@ struct resource * __request_region(struct resource *parent, 
	res->name = name;

	res->start = start;

	res->end = start + n - 1;

	res->flags = IORESOURCE_BUSY;

	res->flags |= flags;

	res->flags = resource_type(parent);

	res->flags |= IORESOURCE_BUSY | flags;



	write_lock(&resource_lock);