Commit 63a76944 authored Oct 25, 2010 by Somnath Kotur Committed by David S. Miller Oct 25, 2010

be2net: Call netif_carier_off() after register_netdev()

Calling netif_carrier_off before register_netdev was causing the network interface
to miss a linkwatch pending event leading to an inconsistent state if the link
is not up when interface is initialized.This is now invoked after register_netdev.

Signed-off-by: Somnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 18edc84c

drivers/net/benet/be_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2556,7 +2556,6 @@ static void be_netdev_init(struct net_device *netdev)
		netif_napi_add(netdev, &adapter->tx_eq.napi, be_poll_tx_mcc,
		BE_NAPI_WEIGHT);

		netif_carrier_off(netdev);
		netif_stop_queue(netdev);
		}

		@@ -2865,6 +2864,7 @@ static int __devinit be_probe(struct pci_dev *pdev,
		status = register_netdev(netdev);
		if (status != 0)
		goto unsetup;
		netif_carrier_off(netdev);

		dev_info(&pdev->dev, "%s port %d\n", nic_name(pdev), adapter->port_num);
		return 0;