Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62f9cfa3 authored by Alan Stern's avatar Alan Stern Committed by Greg Kroah-Hartman
Browse files

USB: don't choose configs with no interfaces 



This patch (as1372) fixes a bug in the routine that chooses the
default configuration to install when a new USB device is detected.
The algorithm is supposed to look for a config whose first interface
is for a non-vendor-specific class.  But the way it's currently
written, it will also accept a config with no interfaces at all, which
is not very useful.  (Believe it or not, such things do exist.)

Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Tested-by: default avatarAndrew Victor <avictor.za@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent c3baa19b

drivers/usb/core/generic.c

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ int usb_choose_configuration(struct usb_device *udev) 
		 * than a vendor-specific driver. */

		else if (udev->descriptor.bDeviceClass !=

						USB_CLASS_VENDOR_SPEC &&

				(!desc || desc->bInterfaceClass !=

				(desc && desc->bInterfaceClass !=

						USB_CLASS_VENDOR_SPEC)) {

			best = c;

			break;