Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62ed853c authored by Dan Carpenter's avatar Dan Carpenter Committed by Wim Van Sebroeck
Browse files

watchdog: w83977f_wdt: underflow in wdt_set_timeout() 



"t" is controlled by the user.  If "t" is a very large integer then it
could lead to a negative "tmrval".  We cap the upper bound of "tmrval"
but, in the current code, we allow negatives.  This is a bug and it
causes a static checker warning.  Let's make "tmrval" unsigned to avoid
this problem.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 4c30737c

drivers/watchdog/w83977f_wdt.c

+1 −1
Original line number Diff line number Diff line
@@ -224,7 +224,7 @@ static int wdt_keepalive(void) 


static int wdt_set_timeout(int t)

{

	int tmrval;

	unsigned int tmrval;



	/*

	 * Convert seconds to watchdog counter time units, rounding up.