Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62ebdc25 authored by Łukasz Rymanowski's avatar Łukasz Rymanowski Committed by Marcel Holtmann
Browse files

Bluetooth: Fix incorrect bits for LE states 



This patch fixes incorrect checks for LE states.
Issues found when doing mgmt tests for scenario
when Linux Kernel should do connectable advertising
while connected.

Signed-off-by: default avatarŁukasz Rymanowski <lukasz.rymanowski@codecoup.pl>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 06633ee1

net/bluetooth/hci_request.c

+3 −3
Original line number Diff line number Diff line
@@ -934,8 +934,8 @@ static bool is_advertising_allowed(struct hci_dev *hdev, bool connectable) 
		/* Slave connection state and connectable mode bit 38

		 * and scannable bit 21.

		 */

		if (connectable && (!(hdev->le_states[4] & 0x01) ||

				    !(hdev->le_states[2] & 0x40)))

		if (connectable && (!(hdev->le_states[4] & 0x40) ||

				    !(hdev->le_states[2] & 0x20)))

			return false;

	}
@@ -948,7 +948,7 @@ static bool is_advertising_allowed(struct hci_dev *hdev, bool connectable) 
		/* Master connection state and connectable mode bit 35 and

		 * scannable 19.

		 */

		if (connectable && (!(hdev->le_states[4] & 0x10) ||

		if (connectable && (!(hdev->le_states[4] & 0x08) ||

				    !(hdev->le_states[2] & 0x08)))

			return false;

	}