Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 62783679 authored by Roel Kluin's avatar Roel Kluin Committed by Russell King
Browse files

[ARM] am79c961a: platform_get_irq() may return signed unnoticed 



dev->irq is unsigned, platform_get_irq() may return signed unnoticed

Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 26eed9a5

drivers/net/arm/am79c961a.c

+7 −3
Original line number Original line Diff line number Diff line
@@ -693,11 +693,15 @@ static int __init am79c961_probe(struct platform_device *pdev) 
	 * done by the ether bootp loader.

	 * done by the ether bootp loader.

	 */

	 */

	dev->base_addr = res->start;

	dev->base_addr = res->start;

	dev->irq = platform_get_irq(pdev, 0);

	ret = platform_get_irq(pdev, 0);





	if (ret < 0) {

		ret = -ENODEV;

		ret = -ENODEV;

	if (dev->irq < 0)

		goto nodev;

		goto nodev;

	}

	dev->irq = ret;



	ret = -ENODEV;

	if (!request_region(dev->base_addr, 0x18, dev->name))

	if (!request_region(dev->base_addr, 0x18, dev->name))

		goto nodev;

		goto nodev;