Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 618fad95 authored by Dotan Barak's avatar Dotan Barak Committed by David S. Miller
Browse files

net/mlx4_core: Replace sscanf() with kstrtoint() 



It is not safe to use sscanf.

Signed-off-by: default avatarDotan Barak <dotanb@dev.mellanox.com>
Signed-off-by: default avatarVladimir Sokolovsky <vlad@mellanox.com>
Signed-off-by: default avatarAmir Vadai <amirv@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 42f1e902

drivers/net/ethernet/mellanox/mlx4/main.c

+3 −3
Original line number Diff line number Diff line
@@ -839,11 +839,11 @@ static ssize_t set_port_ib_mtu(struct device *dev, 
		return -EINVAL;

	}



	err = sscanf(buf, "%d", &mtu);

	if (err > 0)

	err = kstrtoint(buf, 0, &mtu);

	if (!err)

		ibta_mtu = int_to_ibta_mtu(mtu);



	if (err <= 0 || ibta_mtu < 0) {

	if (err || ibta_mtu < 0) {

		mlx4_err(mdev, "%s is invalid IBTA mtu\n", buf);

		return -EINVAL;

	}