Commit 60e1b74c authored Mar 22, 2016 by Nicolai Stange Committed by Herbert Xu Apr 05, 2016

lib/mpi: mpi_read_raw_from_sgl(): purge redundant clearing of nbits



In mpi_read_raw_from_sgl(), unsigned nbits is calculated as follows:

  nbits = nbytes * 8;

and redundantly cleared later on if nbytes == 0:

  if (nbytes > 0)
    ...
  else
    nbits = 0;

Purge this redundant clearing for the sake of clarity.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ab1e912e

lib/mpi/mpicoder.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -461,8 +461,6 @@ MPI mpi_read_raw_from_sgl(struct scatterlist *sgl, unsigned int nbytes)

	if (nbytes > 0)		if (nbytes > 0)
	nbits -= count_leading_zeros((u8 )(sg_virt(sgl) + lzeros));		nbits -= count_leading_zeros((u8 )(sg_virt(sgl) + lzeros));
	else
	nbits = 0;

	nlimbs = DIV_ROUND_UP(nbytes, BYTES_PER_MPI_LIMB);		nlimbs = DIV_ROUND_UP(nbytes, BYTES_PER_MPI_LIMB);
	val = mpi_alloc(nlimbs);		val = mpi_alloc(nlimbs);