Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60b61a6f authored by NeilBrown's avatar NeilBrown Committed by Linus Torvalds
Browse files

kmod: correct documentation of return status of request_module 



If request_module() successfully runs modprobe, but modprobe exits with a
non-zero status, then the return value from request_module() will be that
(positive) error status.  So the return from request_module can be:

 negative errno
 zero for success
 positive exit code.

Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b4cc0efe

kernel/kmod.c

+5 −4
Original line number Diff line number Diff line
@@ -114,10 +114,11 @@ static int call_modprobe(char *module_name, int wait) 
 * @...: arguments as specified in the format string

 *

 * Load a module using the user mode module loader. The function returns

 * zero on success or a negative errno code on failure. Note that a

 * successful module load does not mean the module did not then unload

 * and exit on an error of its own. Callers must check that the service

 * they requested is now available not blindly invoke it.

 * zero on success or a negative errno code or positive exit code from

 * "modprobe" on failure. Note that a successful module load does not mean

 * the module did not then unload and exit on an error of its own. Callers

 * must check that the service they requested is now available not blindly

 * invoke it.

 *

 * If module auto-loading support is disabled then this function

 * becomes a no-operation.