Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60a5ca01 authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Daniel Vetter
Browse files

drm/i915: Add locking around framebuffer_references-- 



obj->framebuffer_references isn't an atomic_t so the decrement needs to
be protected by some lock. struct_mutex seems like the appropriate lock
here, and we may already take it for the obj unref anyway.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 642f9bb5

drivers/gpu/drm/i915/intel_display.c

+4 −1
Original line number Diff line number Diff line
@@ -11594,11 +11594,14 @@ static void intel_setup_outputs(struct drm_device *dev) 


static void intel_user_framebuffer_destroy(struct drm_framebuffer *fb)

{

	struct drm_device *dev = fb->dev;

	struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);



	drm_framebuffer_cleanup(fb);

	mutex_lock(&dev->struct_mutex);

	WARN_ON(!intel_fb->obj->framebuffer_references--);

	drm_gem_object_unreference_unlocked(&intel_fb->obj->base);

	drm_gem_object_unreference(&intel_fb->obj->base);

	mutex_unlock(&dev->struct_mutex);

	kfree(intel_fb);

}