Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60a0f56f authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

serial: meson: remove redundant initialization of variable id 



[ Upstream commit 021212f5335229ed12e3d31f9b7d30bd3bb66f7d ]

The variable id being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed. Since id is just being used in a for-loop
inside a local scope, move the declaration of id to that scope.

Reviewed-by: default avatarKevin Hilman <khilman@baylibre.com>
Reviewed-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210426101106.9122-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Stable-dep-of: 2a1d728f20ed ("tty: serial: meson: fix hard LOCKUP on crtscts mode")
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent eb9d94bd

drivers/tty/serial/meson_uart.c

+2 −1
Original line number Diff line number Diff line
@@ -668,12 +668,13 @@ static int meson_uart_probe(struct platform_device *pdev) 
	struct resource *res_mem, *res_irq;

	struct uart_port *port;

	int ret = 0;

	int id = -1;



	if (pdev->dev.of_node)

		pdev->id = of_alias_get_id(pdev->dev.of_node, "serial");



	if (pdev->id < 0) {

		int id;



		for (id = AML_UART_PORT_OFFSET; id < AML_UART_PORT_NUM; id++) {

			if (!meson_ports[id]) {

				pdev->id = id;