Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 60964816 authored by Andrzej Hajda's avatar Andrzej Hajda Committed by Benjamin Herrenschmidt
Browse files

powerpc/powernv/pci: fix iterator signedness 



Unsigned type is always non-negative, so the loop could not end in case
condition is never true.

The problem has been detected using semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci

Signed-off-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 2dd9c11b

arch/powerpc/platforms/powernv/pci-ioda.c

+1 −1
Original line number Diff line number Diff line
@@ -149,7 +149,7 @@ static void pnv_ioda_reserve_pe(struct pnv_phb *phb, int pe_no) 


static struct pnv_ioda_pe *pnv_ioda_alloc_pe(struct pnv_phb *phb)

{

	unsigned long pe = phb->ioda.total_pe_num - 1;

	long pe;



	for (pe = phb->ioda.total_pe_num - 1; pe >= 0; pe--) {

		if (!test_and_set_bit(pe, phb->ioda.pe_alloc))