Commit 605ed714 authored Aug 11, 2021 by Nadezda Lutovinova Committed by Greg Kroah-Hartman Nov 26, 2021

media: rcar-csi2: Add checking to rcsi2_start_receiver()



[ Upstream commit fc41665498332ad394b7db37f23e9394096ddc71 ]

If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs
in the next cycle. That should not be possible now but adding checking
protects from future bugs.
The patch adds checking if format is NULL.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8f55f852

drivers/media/platform/rcar-vin/rcar-csi2.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -474,6 +474,8 @@ static int rcsi2_start(struct rcar_csi2 *priv)

		/* Code is validated in set_fmt. */
		format = rcsi2_code_to_fmt(priv->mf.code);
		if (!format)
		return -EINVAL;

		/*
		* Enable all Virtual Channels.