Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6052cd1a authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller
Browse files

be2net: fix unicast list filling 



The adapter->pmac_id[0] item is used for primary MAC address but
this is not true for adapter->uc_list[0] as is assumed in
be_set_uc_list(). There are N UC addresses copied first from net_device
to adapter->uc_list[1..N] and then N UC addresses from
adapter->uc_list[0..N-1] are sent to HW. So the last UC address is never
stored into HW and address 00:00:00:00;00:00 (from uc_list[0]) is used
instead.

Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Fixes: b7172414 be2net: replace polling with sleeping in the FW completion path
Signed-off-by: default avatarIvan Vecera <cera@cera.cz>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1d0f110a

drivers/net/ethernet/emulex/benet/be_main.c

+1 −2
Original line number Diff line number Diff line
@@ -1695,9 +1695,8 @@ static void be_set_uc_list(struct be_adapter *adapter) 
	}



	if (adapter->update_uc_list) {

		i = 1; /* First slot is claimed by the Primary MAC */



		/* cache the uc-list in adapter array */

		i = 0;

		netdev_for_each_uc_addr(ha, netdev) {

			ether_addr_copy(adapter->uc_list[i].mac, ha->addr);

			i++;