Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f4d3469 authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

media: Hexium Orion: Adjust one function call together with a variable assignment 



The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code place.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 84c62fb9

drivers/media/pci/saa7146/hexium_orion.c

+3 −1
Original line number Diff line number Diff line
@@ -266,7 +266,9 @@ static int hexium_probe(struct saa7146_dev *dev) 


	/* check if this is an old hexium Orion card by looking at

	   a saa7110 at address 0x4e */

	if (0 == (err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ, 0x00, I2C_SMBUS_BYTE_DATA, &data))) {

	err = i2c_smbus_xfer(&hexium->i2c_adapter, 0x4e, 0, I2C_SMBUS_READ,

			     0x00, I2C_SMBUS_BYTE_DATA, &data);

	if (err == 0) {

		pr_info("device is a Hexium HV-PCI6/Orion (old)\n");

		/* we store the pointer in our private data field */

		dev->ext_priv = hexium;