Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f286ec2 authored by Israel Rukshin's avatar Israel Rukshin Committed by Greg Kroah-Hartman
Browse files

nvmet-rdma: fix response use after free 



[ Upstream commit d7dcdf9d4e15189ecfda24cc87339a3425448d5c ]

nvmet_rdma_release_rsp() may free the response before using it at error
flow.

Fixes: 8407879c ("nvmet-rdma: fix possible bogus dereference under heavy load")
Signed-off-by: default avatarIsrael Rukshin <israelr@mellanox.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b2d58756

drivers/nvme/target/rdma.c

+2 −1
Original line number Diff line number Diff line
@@ -529,6 +529,7 @@ static void nvmet_rdma_send_done(struct ib_cq *cq, struct ib_wc *wc) 
{

	struct nvmet_rdma_rsp *rsp =

		container_of(wc->wr_cqe, struct nvmet_rdma_rsp, send_cqe);

	struct nvmet_rdma_queue *queue = cq->cq_context;



	nvmet_rdma_release_rsp(rsp);
@@ -536,7 +537,7 @@ static void nvmet_rdma_send_done(struct ib_cq *cq, struct ib_wc *wc) 
		     wc->status != IB_WC_WR_FLUSH_ERR)) {

		pr_err("SEND for CQE 0x%p failed with status %s (%d).\n",

			wc->wr_cqe, ib_wc_status_msg(wc->status), wc->status);

		nvmet_rdma_error_comp(rsp->queue);

		nvmet_rdma_error_comp(queue);

	}

}