Commit 5eff5be0 authored Jun 13, 2011 by Dan Carpenter Committed by Nicholas Bellinger Jun 24, 2011

target: Drop bogus ERR_PTR usage in target_fabric_configfs_init



In the original code, there were several places inside the
target_fabric_configfs_init() function that returned NULL on error
and one place the returned an ERR_PTR.  There are two places that
call this function and they only check for NULL returns; they don't
check for ERR_PTRs.  So I've changed the ERR_PTR so now the function
only returns NULL on error.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

parent 552523dc

drivers/target/target_core_configfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -312,7 +312,7 @@ struct target_fabric_configfs *target_fabric_configfs_init(

		tf = kzalloc(sizeof(struct target_fabric_configfs), GFP_KERNEL);
		if (!(tf))
		return ERR_PTR(-ENOMEM);
		return NULL;

		INIT_LIST_HEAD(&tf->tf_list);
		atomic_set(&tf->tf_access_cnt, 0);