Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5efc7259 authored by David Collins's avatar David Collins
Browse files

clk: avoid returning local variable pointers during clock registration 



Several clock drivers initialize the clk_hw init element to a
local variable before calling [devm_]clk_hw_register() on it.
This style is fine.  However, the init pointer value becomes
invalid as soon as the registration function returns.  Clear
the init pointer to avoid the possibility of accessing an
invalid memory address after registration completes.

Change-Id: I3ae72c2c7ebc30e443c7034d072591827f4342aa
Signed-off-by: default avatarDavid Collins <collinsd@codeaurora.org>
parent 13371263

drivers/clk/clk-divider.c

+1 −0
Original line number Diff line number Diff line
@@ -497,6 +497,7 @@ static struct clk_hw *_register_divider(struct device *dev, const char *name, 
	/* register the clock */

	hw = &div->hw;

	ret = clk_hw_register(dev, hw);

	hw->init = NULL;

	if (ret) {

		kfree(div);

		hw = ERR_PTR(ret);

drivers/clk/clk-fixed-factor.c

+1 −0
Original line number Diff line number Diff line
@@ -95,6 +95,7 @@ struct clk_hw *clk_hw_register_fixed_factor(struct device *dev, 


	hw = &fix->hw;

	ret = clk_hw_register(dev, hw);

	hw->init = NULL;

	if (ret) {

		kfree(fix);

		hw = ERR_PTR(ret);

drivers/clk/clk-fixed-rate.c

+1 −0
Original line number Diff line number Diff line
@@ -83,6 +83,7 @@ struct clk_hw *clk_hw_register_fixed_rate_with_accuracy(struct device *dev, 
	/* register the clock */

	hw = &fixed->hw;

	ret = clk_hw_register(dev, hw);

	hw->init = NULL;

	if (ret) {

		kfree(fixed);

		hw = ERR_PTR(ret);

drivers/clk/clk-fractional-divider.c

+1 −0
Original line number Diff line number Diff line
@@ -161,6 +161,7 @@ struct clk_hw *clk_hw_register_fractional_divider(struct device *dev, 


	hw = &fd->hw;

	ret = clk_hw_register(dev, hw);

	hw->init = NULL;

	if (ret) {

		kfree(fd);

		hw = ERR_PTR(ret);

drivers/clk/clk-gate.c

+1 −0
Original line number Diff line number Diff line
@@ -158,6 +158,7 @@ struct clk_hw *clk_hw_register_gate(struct device *dev, const char *name, 


	hw = &gate->hw;

	ret = clk_hw_register(dev, hw);

	hw->init = NULL;

	if (ret) {

		kfree(gate);

		hw = ERR_PTR(ret);