Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ee48064 authored by Osama Muhammad's avatar Osama Muhammad Committed by Greg Kroah-Hartman
Browse files

regulator: Fix error checking for debugfs_create_dir 



[ Upstream commit 2bf1c45be3b8f3a3f898d0756c1282f09719debd ]

This patch fixes the error checking in core.c in debugfs_create_dir.
The correct way to check if an error occurred is 'IS_ERR' inline function.

Signed-off-by: default avatarOsama Muhammad <osmtendev@gmail.com>
Suggested-by: default avatarIvan Orlov <ivan.orlov0322@gmail.com>
Link: https://lore.kernel.org/r/20230515172938.13338-1-osmtendev@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 417bd547

drivers/regulator/core.c

+2 −2
Original line number Diff line number Diff line
@@ -4181,7 +4181,7 @@ static void rdev_init_debugfs(struct regulator_dev *rdev) 
	}



	rdev->debugfs = debugfs_create_dir(rname, debugfs_root);

	if (!rdev->debugfs) {

	if (IS_ERR(rdev->debugfs)) {

		rdev_warn(rdev, "Failed to create debugfs directory\n");

		return;

	}
@@ -4843,7 +4843,7 @@ static int __init regulator_init(void) 
	ret = class_register(&regulator_class);



	debugfs_root = debugfs_create_dir("regulator", NULL);

	if (!debugfs_root)

	if (IS_ERR(debugfs_root))

		pr_warn("regulator: Failed to create debugfs directory\n");



	debugfs_create_file("supply_map", 0444, debugfs_root, NULL,