Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5e86830c authored by Sujeev Dias's avatar Sujeev Dias
Browse files

mhi: core: clear BHIE RX vector registers during init 



Power on reset values for BHIE RX vector registers are undefined,
manually clear it during init.

CRs-Fixed: 2373857
Change-Id: Iae386ba90cd4743e87fef8a5496d0e48d3e31a0c
Signed-off-by: default avatarSujeev Dias <sdias@codeaurora.org>
parent 3b3e314b

drivers/bus/mhi/core/mhi_init.c

+26 −2
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/* Copyright (c) 2018, The Linux Foundation. All rights reserved. */

/* Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. */



#include <linux/debugfs.h>

#include <linux/device.h>
@@ -1239,6 +1239,7 @@ EXPORT_SYMBOL(mhi_alloc_controller); 
int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)

{

	int ret;

	u32 bhie_off;



	mutex_lock(&mhi_cntrl->pm_mutex);
@@ -1258,16 +1259,39 @@ int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl) 
	 * allocate rddm table if specified, this table is for debug purpose

	 * so we'll ignore erros

	 */

	if (mhi_cntrl->rddm_size)

	if (mhi_cntrl->rddm_size) {

		mhi_alloc_bhie_table(mhi_cntrl, &mhi_cntrl->rddm_image,

				     mhi_cntrl->rddm_size);



		/*

		 * This controller supports rddm, we need to manually clear

		 * BHIE RX registers since por values are undefined.

		 */

		ret = mhi_read_reg(mhi_cntrl, mhi_cntrl->regs, BHIEOFF,

				   &bhie_off);

		if (ret) {

			MHI_ERR("Error getting bhie offset\n");

			goto bhie_error;

		}



		memset_io(mhi_cntrl->regs + bhie_off + BHIE_RXVECADDR_LOW_OFFS,

			  0, BHIE_RXVECSTATUS_OFFS - BHIE_RXVECADDR_LOW_OFFS +

			  4);

	}



	mhi_cntrl->pre_init = true;



	mutex_unlock(&mhi_cntrl->pm_mutex);



	return 0;



bhie_error:

	if (mhi_cntrl->rddm_image) {

		mhi_free_bhie_table(mhi_cntrl, mhi_cntrl->rddm_image);

		mhi_cntrl->rddm_image = NULL;

	}

	mhi_deinit_free_irq(mhi_cntrl);



error_setup_irq:

	mhi_deinit_dev_ctxt(mhi_cntrl);