Commit 5df848f3 authored Apr 05, 2015 by Julia Lawall Committed by Samuel Ortiz Apr 06, 2015

NFC: pn533: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent 9421ce10

drivers/nfc/pn533.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2554,8 +2554,10 @@ static int pn533_data_exchange_complete(struct pn533 dev, void _arg,
		}

		skb = pn533_build_response(dev);
		if (!skb)
		if (!skb) {
		rc = -ENOMEM;
		goto error;
		}

		arg->cb(arg->cb_context, skb, 0);
		kfree(arg);