Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5dcddebb authored by Boris Brezillon's avatar Boris Brezillon Committed by Miquel Raynal
Browse files

mtd: rawnand: Kill cafe_nand_bug() 



Leaving a function pointer to NULL should be enough to trigger a NULL
pointer exception, and anyway, if we want to BUG() when some missing
hooks are called, this should be done in the core, so let's drop the
cafe_nand_bug() dummy function.

Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent a58d0b4d

drivers/mtd/nand/raw/cafe_nand.c

+0 −8
Original line number Diff line number Diff line
@@ -345,11 +345,6 @@ static irqreturn_t cafe_nand_interrupt(int irq, void *id) 
	return IRQ_HANDLED;

}



static void cafe_nand_bug(struct mtd_info *mtd)

{

	BUG();

}



static int cafe_nand_write_oob(struct mtd_info *mtd,

			       struct nand_chip *chip, int page)

{
@@ -760,9 +755,6 @@ static int cafe_nand_probe(struct pci_dev *pdev, 
	cafe->nand.ecc.size = mtd->writesize;

	cafe->nand.ecc.bytes = 14;

	cafe->nand.ecc.strength = 4;

	cafe->nand.ecc.hwctl  = (void *)cafe_nand_bug;

	cafe->nand.ecc.calculate = (void *)cafe_nand_bug;

	cafe->nand.ecc.correct  = (void *)cafe_nand_bug;

	cafe->nand.ecc.write_page = cafe_nand_write_page_lowlevel;

	cafe->nand.ecc.write_oob = cafe_nand_write_oob;

	cafe->nand.ecc.read_page = cafe_nand_read_page;